netdev - Re: [PATCH net-next 16/17] net: dsa: move tag

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0bda268f-95f4-5e7a-6bae-ba61a37d93e9@gmail.com>
Date:   Mon, 21 Nov 2022 12:38:16 -0800
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Vladimir Oltean <vladimir.oltean@....com>, netdev@...r.kernel.org
Cc:     Andrew Lunn <andrew@...n.ch>, Vladimir Oltean <olteanv@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>
Subject: Re: [PATCH net-next 16/17] net: dsa: move tag_8021q headers to their
 proper place

On 11/21/22 05:55, Vladimir Oltean wrote:
> tag_8021q definitions are all over the place. Some are exported to
> linux/dsa/8021q.h (visible by DSA core, taggers, switch drivers and
> everyone else), and some are in dsa_priv.h.
> 
> Move the structures that don't need external visibility into tag_8021q.c,
> and the ones which don't need the world or switch drivers to see them
> into tag_8021q.h.
> 
> We also have the tag_8021q.h inclusion from switch.c, which is basically
> the entire reason why tag_8021q.c was built into DSA in commit
> 8b6e638b4be2 ("net: dsa: build tag_8021q.c as part of DSA core").
> I still don't know how to better deal with that, so leave it alone.
> 
> Signed-off-by: Vladimir Oltean <vladimir.oltean@....com>

Reviewed-by: Florian Fainelli <f.fainelli@...il.com>
-- 
Florian