netdev - Re: [PATCH net-next 2/8] devlink: use min_t to calculate data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7f70a230-c247-fca4-67ac-0bf906a7cf67@intel.com>
Date:   Mon, 21 Nov 2022 13:16:47 -0800
From:   Jacob Keller <jacob.e.keller@...el.com>
To:     Jakub Kicinski <kuba@...nel.org>
CC:     <netdev@...r.kernel.org>, Jiri Pirko <jiri@...dia.com>
Subject: Re: [PATCH net-next 2/8] devlink: use min_t to calculate data_size



On 11/21/2022 11:06 AM, Jakub Kicinski wrote:
> On Mon, 21 Nov 2022 10:35:34 -0800 Jacob Keller wrote:
>>> Sure, that makes sense.
>>
>> This becomes the only variable in patch 5 of 8. It ends up making the
>> diff look more complicated if I change it back to a combined
>> declare+assign in that patch.
> 
> Don't change it back to declare+assign, then? :)
> In general declare+assign should be used sparingly IMO.
> My eyes are trained to skip right past the variable declarations,
> the goal is to make the code clear, not short :S
> 
> BTW you can probably make DEVLINK_REGION_READ_CHUNK_SIZE a ULL to switch
> from min_t() to min() ?

Fair enough. It looked a bit weird when it was:

u32 data_size;

data_size = ...

But I think thats ok.

Thanks,
Jake