netdev - Re: [PATCH bpf 0/4] bpf, sockmap: Fix some issues with using apply

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87k03o7ipx.fsf@cloudflare.com>
Date:   Mon, 21 Nov 2022 10:35:34 +0100
From:   Jakub Sitnicki <jakub@...udflare.com>
To:     Pengcheng Yang <yangpc@...gsu.com>
Cc:     John Fastabend <john.fastabend@...il.com>, bpf@...r.kernel.org,
        netdev@...r.kernel.org
Subject: Re: [PATCH bpf 0/4] bpf, sockmap: Fix some issues with using
 apply_bytes

On Wed, Nov 16, 2022 at 07:29 PM +08, Pengcheng Yang wrote:
> Patch 0001~0003 fixes three issues with using apply_bytes when redirecting.
> Patch 0004 adds ingress tests for txmsg with apply_bytes in selftests.
>
> Pengcheng Yang (4):
>   bpf, sockmap: Fix repeated calls to sock_put() when msg has more_data
>   bpf, sockmap: Fix missing BPF_F_INGRESS flag when using apply_bytes
>   bpf, sockmap: Fix data loss caused by using apply_bytes on ingress
>     redirect
>   selftests/bpf: Add ingress tests for txmsg with apply_bytes
>
>  include/linux/skmsg.h                      |  1 +
>  net/core/skmsg.c                           |  1 +
>  net/ipv4/tcp_bpf.c                         |  9 +++++++--
>  net/tls/tls_sw.c                           |  1 +
>  tools/testing/selftests/bpf/test_sockmap.c | 18 ++++++++++++++++++
>  5 files changed, 28 insertions(+), 2 deletions(-)

Thanks for the patches. I need a bit more time to review them.