netdev - RE: [PATCH iproute2-next v1] tc_util: Fix no error return when large parent id used

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 21 Nov 2022 02:26:40 +0000
From:   "Lai, Peter Jun Ann" <peter.jun.ann.lai@...el.com>
To:     Stephen Hemminger <stephen@...workplumber.org>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        David Ahern <dsahern@...nel.org>,
        "Gomes, Vinicius" <vinicius.gomes@...el.com>,
        "Jamal Hadi Salim" <jhs@...atatu.com>,
        Cong Wang <xiyou.wangcong@...il.com>,
        "Jiri Pirko" <jiri@...nulli.us>,
        "Zulkifli, Muhammad Husaini" <muhammad.husaini.zulkifli@...el.com>
Subject: RE: [PATCH iproute2-next v1] tc_util: Fix no error return when large
 parent id used

Hi,

> -----Original Message-----
> From: Stephen Hemminger <stephen@...workplumber.org>
> Sent: Friday, November 18, 2022 12:36 AM
> To: Lai, Peter Jun Ann <peter.jun.ann.lai@...el.com>
> Cc: netdev@...r.kernel.org; David Ahern <dsahern@...nel.org>; Gomes,
> Vinicius <vinicius.gomes@...el.com>; Jamal Hadi Salim <jhs@...atatu.com>;
> Cong Wang <xiyou.wangcong@...il.com>; Jiri Pirko <jiri@...nulli.us>;
> Zulkifli, Muhammad Husaini <muhammad.husaini.zulkifli@...el.com>
> Subject: Re: [PATCH iproute2-next v1] tc_util: Fix no error return when large
> parent id used
> 
> On Thu, 17 Nov 2022 13:33:17 +0800
> Lai Peter Jun Ann <jun.ann.lai@...el.com> wrote:
> 
> > This patch is to fix the issue where there is no error return when
> > large value of parent ID is being used. The return value by
> > stroul() is unsigned long int. Hence the datatype for maj and min
> > should defined as unsigned long to avoid overflow issue.
> >
> > Signed-off-by: Muhammad Husaini Zulkifli
> > <muhammad.husaini.zulkifli@...el.com>
> > Signed-off-by: Lai Peter Jun Ann <jun.ann.lai@...el.com>
> 
> Yes, looks good. Will apply to main.
> What about qdisc_handle as well?

Thanks for prompt response. 
I will submit another patch for qdisc_handle.