netdev - Re: [PATCH v2 net 7/7] hsr: Use a single struct for self

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87sfib9wge.fsf@kurt>
Date:   Tue, 22 Nov 2022 10:20:49 +0100
From:   Kurt Kanzenbach <kurt@...utronix.de>
To:     Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
        netdev@...r.kernel.org
Cc:     "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Sebastian Andrzej Siewior <bigeasy@...utronix.de>
Subject: Re: [PATCH v2 net 7/7] hsr: Use a single struct for self_node.

On Mon Nov 21 2022, Sebastian Andrzej Siewior wrote:
> self_node_db is a list_head with one entry of struct hsr_node. The
> purpose is to hold the two MAC addresses of the node itself.
> It is convenient to recycle the structure. However having a list_head
> and fetching always the first entry is not really optimal.
>
> Created a new data strucure contaning the two MAC addresses named
> hsr_self_node. Access that structured like an RCU protected pointer so
                             ^ structure

> it can be replaced on the fly withou blocking the reader.
                               ^ without

>
> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@...utronix.de>

Lacks a Fixes tag. Looks rather like an optimization than a bugfix? So,
maybe this one should go to net-next instead.

[snip]

> +struct hsr_self_node {
> +	unsigned char	macaddress_A[6];
                                    ^ ETH_ALEN

> +	unsigned char	macaddress_B[6];
                                    ^ ETH_ALEN
> +	struct rcu_head	rcu_head;
> +};
> +

Thanks,
Kurt

Download attachment "signature.asc" of type "application/pgp-signature" (862 bytes)