netdev - Re: [PATCH net v2 1/3] nfc: st-nci: fix incorrect validating logic in EVT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9087a472-19a5-f8c2-3d2b-a838bb1c6d96@linaro.org>
Date:   Tue, 22 Nov 2022 12:16:17 +0100
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Martin Faltesek <mfaltesek@...gle.com>, kuba@...nel.org,
        netdev@...r.kernel.org, linux-nfc@...ts.01.org, davem@...emloft.net
Cc:     martin.faltesek@...il.com, christophe.ricard@...il.com,
        groeck@...gle.com, jordy@...ing.systems, krzk@...nel.org,
        sameo@...ux.intel.com, theflamefire89@...il.com,
        duoming@....edu.cn, Denis Efremov <denis.e.efremov@...cle.com>
Subject: Re: [PATCH net v2 1/3] nfc: st-nci: fix incorrect validating logic in
 EVT_TRANSACTION

On 22/11/2022 01:42, Martin Faltesek wrote:
> The first validation check for EVT_TRANSACTION has two different checks
> tied together with logical AND. One is a check for minimum packet length,
> and the other is for a valid aid_tag. If either condition is true (fails),
> then an error should be triggered. The fix is to change && to ||.
> 
> Reported-by: Denis Efremov <denis.e.efremov@...cle.com>
> Reviewed-by: Guenter Roeck <groeck@...gle.com>
> Fixes: 5d1ceb7f5e56 ("NFC: st21nfcb: Add HCI transaction event support")
> Signed-off-by: Martin Faltesek <mfaltesek@...gle.com>
> ---


Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>

Best regards,
Krzysztof