netdev - RE: [PATCH -next] crypto: ccree - Fix section mismatch due to cc_debugfs_global

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <OS0PR01MB59224447AE5AB1A04567EBF2860D9@OS0PR01MB5922.jpnprd01.prod.outlook.com>
Date:   Tue, 22 Nov 2022 11:24:07 +0000
From:   Biju Das <biju.das.jz@...renesas.com>
To:     YueHaibing <yuehaibing@...wei.com>,
        "s.shtylyov@....ru" <s.shtylyov@....ru>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "edumazet@...gle.com" <edumazet@...gle.com>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "pabeni@...hat.com" <pabeni@...hat.com>,
        Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-renesas-soc@...r.kernel.org" 
        <linux-renesas-soc@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH -next] crypto: ccree - Fix section mismatch due to
 cc_debugfs_global_fini()

> Subject: Re: [PATCH -next] crypto: ccree - Fix section mismatch due to
> cc_debugfs_global_fini()
> 
> Sorry， Pls ignore this.

This is real issue, right?

"WARNING: modpost: drivers/crypto/ccree/ccree.o: section mismatch in
reference: init_module (section: .init.text) -> cc_debugfs_global_fini
(section: .exit.text)"


Looks like the committer of the patch without building submitted the patch.
4f1c596df706 ("crypto: ccree - Remove debugfs when platform_driver_register failed")

Cheers,
Biju


> 
> On 2022/11/22 11:05, YueHaibing wrote:
> > cc_debugfs_global_fini() is marked with __exit now, however it is used
> > in __init ccree_init() for cleanup. Remove the __exit annotation to
> > fix build warning:
> >
> > WARNING: modpost: drivers/crypto/ccree/ccree.o: section mismatch in
> > reference: init_module (section: .init.text) -> cc_debugfs_global_fini
> > (section: .exit.text)
> >
> > Fixes: 4f1c596df706 ("crypto: ccree - Remove debugfs when
> > platform_driver_register failed")
> > Signed-off-by: YueHaibing <yuehaibing@...wei.com>
> > ---
> >  drivers/crypto/ccree/cc_debugfs.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/crypto/ccree/cc_debugfs.c
> > b/drivers/crypto/ccree/cc_debugfs.c
> > index 7083767602fc..8f008f024f8f 100644
> > --- a/drivers/crypto/ccree/cc_debugfs.c
> > +++ b/drivers/crypto/ccree/cc_debugfs.c
> > @@ -55,7 +55,7 @@ void __init cc_debugfs_global_init(void)
> >  	cc_debugfs_dir = debugfs_create_dir("ccree", NULL);  }
> >
> > -void __exit cc_debugfs_global_fini(void)
> > +void cc_debugfs_global_fini(void)
> >  {
> >  	debugfs_remove(cc_debugfs_dir);
> >  }