netdev - RE: [Intel-wired-lan] [PATCH] ixgbevf: Fix resource leak in ixgbevf_init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 22 Nov 2022 11:43:57 +0000
From:   "Jankowski, Konrad0" <konrad0.jankowski@...el.com>
To:     Shang XiaoJing <shangxiaojing@...wei.com>,
        "Brandeburg, Jesse" <jesse.brandeburg@...el.com>,
        "Nguyen, Anthony L" <anthony.l.nguyen@...el.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "edumazet@...gle.com" <edumazet@...gle.com>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "pabeni@...hat.com" <pabeni@...hat.com>,
        "jeffrey.t.kirsher@...el.com" <jeffrey.t.kirsher@...el.com>,
        "Rustad, Mark D" <mark.d.rustad@...el.com>,
        "intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: RE: [Intel-wired-lan] [PATCH] ixgbevf: Fix resource leak in
 ixgbevf_init_module()



> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On Behalf Of Shang
> XiaoJing
> Sent: Monday, November 14, 2022 3:58 AM
> To: Brandeburg, Jesse <jesse.brandeburg@...el.com>; Nguyen, Anthony L
> <anthony.l.nguyen@...el.com>; davem@...emloft.net;
> edumazet@...gle.com; kuba@...nel.org; pabeni@...hat.com;
> jeffrey.t.kirsher@...el.com; Rustad, Mark D <mark.d.rustad@...el.com>; intel-
> wired-lan@...ts.osuosl.org; netdev@...r.kernel.org
> Cc: shangxiaojing@...wei.com
> Subject: [Intel-wired-lan] [PATCH] ixgbevf: Fix resource leak in
> ixgbevf_init_module()
> 
> ixgbevf_init_module() won't destroy the workqueue created by
> create_singlethread_workqueue() when pci_register_driver() failed. Add
> destroy_workqueue() in fail path to prevent the resource leak.
> 
> Similar to the handling of u132_hcd_init in commit f276e002793c
> ("usb: u132-hcd: fix resource leak")
> 
> Fixes: 40a13e2493c9 ("ixgbevf: Use a private workqueue to avoid certain possible
> hangs")
> Signed-off-by: Shang XiaoJing <shangxiaojing@...wei.com>
> ---
>  drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c | 10 +++++++++-
>  1 file changed, 9 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c
> b/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c
> index 99933e89717a..e338fa572793 100644
> --- a/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c
> +++ b/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c
> @@ -4869,6 +4869,8 @@ static struct pci_driver ixgbevf_driver = {

Tested-by: Konrad Jankowski <konrad0.jankowski@...el.com>