netdev - Re: [PATCH net v2] bnx2x: fix pci device refcount leak in bnx2x_vf_is_pcie

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y3y/TF3ryvKH9BG6@unreal>
Date:   Tue, 22 Nov 2022 14:23:40 +0200
From:   Leon Romanovsky <leon@...nel.org>
To:     Yang Yingliang <yangyingliang@...wei.com>
Cc:     netdev@...r.kernel.org, aelior@...vell.com, skalluru@...vell.com,
        manishc@...vell.com, davem@...emloft.net, edumazet@...gle.com,
        kuba@...nel.org, pabeni@...hat.com
Subject: Re: [PATCH net v2] bnx2x: fix pci device refcount leak in
 bnx2x_vf_is_pcie_pending()

On Sat, Nov 19, 2022 at 03:02:02PM +0800, Yang Yingliang wrote:
> As comment of pci_get_domain_bus_and_slot() says, it returns
> a pci device with refcount increment, when finish using it,
> the caller must decrement the reference count by calling
> pci_dev_put(). Call pci_dev_put() before returning from
> bnx2x_vf_is_pcie_pending() to avoid refcount leak.
> 
> Fixes: b56e9670ffa4 ("bnx2x: Prepare device and initialize VF database")
> Suggested-by: Jakub Kicinski <kuba@...nel.org>
> Signed-off-by: Yang Yingliang <yangyingliang@...wei.com>
> ---
> v1 -> v2:
>   Unindents success path suggested by Jakub.
>   And Cc all pepole in the maintainer list.
> ---
>  drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c | 12 ++++++++----
>  1 file changed, 8 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c
> index 11d15cd03600..77d4cb4ad782 100644
> --- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c
> +++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_sriov.c
> @@ -795,16 +795,20 @@ static void bnx2x_vf_enable_traffic(struct bnx2x *bp, struct bnx2x_virtf *vf)
>  
>  static u8 bnx2x_vf_is_pcie_pending(struct bnx2x *bp, u8 abs_vfid)
>  {
> -	struct pci_dev *dev;
>  	struct bnx2x_virtf *vf = bnx2x_vf_by_abs_fid(bp, abs_vfid);
> +	struct pci_dev *dev;
> +	bool pending;
>  
>  	if (!vf)
>  		return false;
>  
>  	dev = pci_get_domain_bus_and_slot(vf->domain, vf->bus, vf->devfn);
> -	if (dev)
> -		return bnx2x_is_pcie_pending(dev);
> -	return false;
> +	if (!dev)
> +		return false;
> +	pending = bnx2x_is_pcie_pending(dev);
> +	pci_dev_put(dev);
> +
> +	return pending;
>  }
>  

Thanks,
Reviewed-by: Leon Romanovsky <leonro@...dia.com>