netdev - Re: [PATCH net] net: ethernet: wiznet: w5300: free irq when alloc link_name failed in w5300_hw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y3zAUi5phHtYkjbb@unreal>
Date:   Tue, 22 Nov 2022 14:28:02 +0200
From:   Leon Romanovsky <leon@...nel.org>
To:     Gaosheng Cui <cuigaosheng1@...wei.com>
Cc:     davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
        pabeni@...hat.com, thomas.lendacky@....com, shayagr@...zon.com,
        wsa+renesas@...g-engineering.com, msink@...monline.ru,
        netdev@...r.kernel.org
Subject: Re: [PATCH net] net: ethernet: wiznet: w5300: free irq when alloc
 link_name failed in w5300_hw_probe()

On Sat, Nov 19, 2022 at 03:10:07PM +0800, Gaosheng Cui wrote:
> When alloc link_name failed in w5300_hw_probe(), irq has not been
> freed. Fix it.
> 
> Fixes: 9899b81e7ca5 ("Ethernet driver for the WIZnet W5300 chip")
> Signed-off-by: Gaosheng Cui <cuigaosheng1@...wei.com>
> ---
>  drivers/net/ethernet/wiznet/w5300.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/wiznet/w5300.c b/drivers/net/ethernet/wiznet/w5300.c
> index b0958fe8111e..5571d4c365e9 100644
> --- a/drivers/net/ethernet/wiznet/w5300.c
> +++ b/drivers/net/ethernet/wiznet/w5300.c
> @@ -572,8 +572,10 @@ static int w5300_hw_probe(struct platform_device *pdev)
>  	priv->link_gpio = data ? data->link_gpio : -EINVAL;
>  	if (gpio_is_valid(priv->link_gpio)) {
>  		char *link_name = devm_kzalloc(&pdev->dev, 16, GFP_KERNEL);
> -		if (!link_name)
> +		if (!link_name) {
> +			free_irq(irq, ndev);
>  			return -ENOMEM;
> +		}
>  		snprintf(link_name, 16, "%s-link", name);
>  		priv->link_irq = gpio_to_irq(priv->link_gpio);
>  		if (request_any_context_irq(priv->link_irq, w5300_detect_link,

  579                 if (request_any_context_irq(priv->link_irq, w5300_detect_link,
  580                                 IRQF_TRIGGER_RISING | IRQF_TRIGGER_FALLING,
  581                                 link_name, priv->ndev) < 0)
  582                         priv->link_gpio = -EINVAL;

You should call to same free_irq(irq, ndev) in this "if" too.

Thanks

> -- 
> 2.25.1
>