[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <Y3zhhLE8G2zspVvR@lunn.ch>
Date: Tue, 22 Nov 2022 15:49:40 +0100
From: Andrew Lunn <andrew@...n.ch>
To: Maxim Korotkov <korotkov.maxim.s@...il.com>
Cc: "David S. Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>,
Paolo Abeni <pabeni@...hat.com>,
Guangbin Huang <huangguangbin2@...wei.com>,
Alexander Lobakin <alexandr.lobakin@...el.com>,
"Keller, Jacob E" <jacob.e.keller@...el.com>,
Tom Rix <trix@...hat.com>, Marco Bonelli <marco@...eim.net>,
Edward Cree <ecree@...arflare.com>, netdev@...r.kernel.org,
linux-kernel@...r.kernel.org, lvc-project@...uxtesting.org
Subject: Re: [PATCH v3] ethtool: avoiding integer overflow in
ethtool_phys_id()
On Tue, Nov 22, 2022 at 03:29:01PM +0300, Maxim Korotkov wrote:
> The value of an arithmetic expression "n * id.data" is subject
> to possible overflow due to a failure to cast operands to a larger data
> type before performing arithmetic. Used macro for multiplication instead
> operator for avoiding overflow.
>
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
>
> Signed-off-by: Maxim Korotkov <korotkov.maxim.s@...il.com>
Reviewed-by: Andrew Lunn <andrew@...n.ch>
Andrew
Powered by blists - more mailing lists