netdev - Re: [PATCH v2] igbvf: Regard vf reset nack as success

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 22 Nov 2022 17:22:59 +0100
From:   Maciej Fijalkowski <maciej.fijalkowski@...el.com>
To:     Akihiko Odaki <akihiko.odaki@...nix.com>
CC:     <linux-kernel@...r.kernel.org>, <netdev@...r.kernel.org>,
        <intel-wired-lan@...ts.osuosl.org>,
        Jesse Brandeburg <jesse.brandeburg@...el.com>,
        Tony Nguyen <anthony.l.nguyen@...el.com>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        "Yan Vugenfirer" <yan@...nix.com>,
        Yuri Benditovich <yuri.benditovich@...nix.com>
Subject: Re: [PATCH v2] igbvf: Regard vf reset nack as success

On Wed, Nov 23, 2022 at 12:26:30AM +0900, Akihiko Odaki wrote:
> vf reset nack actually represents the reset operation itself is
> performed but no address is assigned. Therefore, e1000_reset_hw_vf
> should fill the "perm_addr" with the zero address and return success on
> such an occasion. This prevents its callers in netdev.c from saying PF
> still resetting, and instead allows them to correctly report that no
> address is assigned.

What's the v1->v2 diff?
Probably route to net and add fixes tag?

> 
> Signed-off-by: Akihiko Odaki <akihiko.odaki@...nix.com>
> ---
>  drivers/net/ethernet/intel/igbvf/vf.c | 15 ++++++++++++---
>  1 file changed, 12 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/net/ethernet/intel/igbvf/vf.c b/drivers/net/ethernet/intel/igbvf/vf.c
> index b8ba3f94c363..2691ae2a8002 100644
> --- a/drivers/net/ethernet/intel/igbvf/vf.c
> +++ b/drivers/net/ethernet/intel/igbvf/vf.c
> @@ -1,6 +1,8 @@
>  // SPDX-License-Identifier: GPL-2.0
>  /* Copyright(c) 2009 - 2018 Intel Corporation. */
>  
> +#include <linux/etherdevice.h>
> +
>  #include "vf.h"
>  
>  static s32 e1000_check_for_link_vf(struct e1000_hw *hw);
> @@ -131,11 +133,18 @@ static s32 e1000_reset_hw_vf(struct e1000_hw *hw)
>  		/* set our "perm_addr" based on info provided by PF */
>  		ret_val = mbx->ops.read_posted(hw, msgbuf, 3);
>  		if (!ret_val) {
> -			if (msgbuf[0] == (E1000_VF_RESET |
> -					  E1000_VT_MSGTYPE_ACK))
> +			switch (msgbuf[0]) {
> +			case E1000_VF_RESET | E1000_VT_MSGTYPE_ACK:
>  				memcpy(hw->mac.perm_addr, addr, ETH_ALEN);
> -			else
> +				break;
> +
> +			case E1000_VF_RESET | E1000_VT_MSGTYPE_NACK:
> +				eth_zero_addr(hw->mac.perm_addr);
> +				break;
> +
> +			default:
>  				ret_val = -E1000_ERR_MAC_INIT;
> +			}
>  		}
>  	}
>  
> -- 
> 2.38.1
>