netdev - Re: [PATCH net-next V2] tcp: Fix build break when CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANn89i+6wuATYqe2eN2+P4rA6_EwfZwzWhpZb+ZnxWHp+yG5sQ@mail.gmail.com>
Date:   Tue, 22 Nov 2022 10:48:05 -0800
From:   Eric Dumazet <edumazet@...gle.com>
To:     Saeed Mahameed <saeed@...nel.org>
Cc:     "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Saeed Mahameed <saeedm@...dia.com>, netdev@...r.kernel.org,
        Tariq Toukan <tariqt@...dia.com>,
        Geert Uytterhoeven <geert+renesas@...der.be>,
        Matthieu Baerts <matthieu.baerts@...sares.net>,
        Jamie Bainbridge <jamie.bainbridge@...il.com>
Subject: Re: [PATCH net-next V2] tcp: Fix build break when CONFIG_IPV6=n

On Tue, Nov 22, 2022 at 10:42 AM Saeed Mahameed <saeed@...nel.org> wrote:
>
> From: Saeed Mahameed <saeedm@...dia.com>
>
> The cited commit caused the following build break when CONFIG_IPV6 was
> disabled
>
> net/ipv4/tcp_input.c: In function ‘tcp_syn_flood_action’:
> include/net/sock.h:387:37: error: ‘const struct sock_common’ has no member named ‘skc_v6_rcv_saddr’; did you mean ‘skc_rcv_saddr’?
>
> Fix by using inet6_rcv_saddr() macro which handles this situation
> nicely.
>
> Fixes: d9282e48c608 ("tcp: Add listening address to SYN flood message")
> Signed-off-by: Saeed Mahameed <saeedm@...dia.com>
> Reported-by: Geert Uytterhoeven <geert+renesas@...der.be>
> CC: Matthieu Baerts <matthieu.baerts@...sares.net>
> CC: Jamie Bainbridge <jamie.bainbridge@...il.com>


Thanks.

Reviewed-by: Eric Dumazet <edumazet@...gle.com>