netdev - Re: [PATCH net-next] tsnep: Fix rotten packets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c6d4a25c-8bc0-89e9-dbec-f493c45f99ed@engleder-embedded.com>
Date:   Tue, 22 Nov 2022 20:25:52 +0100
From:   Gerhard Engleder <gerhard@...leder-embedded.com>
To:     Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org
Cc:     davem@...emloft.net, kuba@...nel.org, edumazet@...gle.com
Subject: Re: [PATCH net-next] tsnep: Fix rotten packets

On 22.11.22 15:51, Paolo Abeni wrote:
> On Sat, 2022-11-19 at 22:18 +0100, Gerhard Engleder wrote:
>> If PTP synchronisation is done every second, then sporadic the interval
>> is higher than one second:
>>
>> ptp4l[696.582]: master offset        -17 s2 freq   -1891 path delay 573
>> ptp4l[697.582]: master offset        -22 s2 freq   -1901 path delay 573
>> ptp4l[699.368]: master offset         -1 s2 freq   -1887 path delay 573
>>        ^^^^^^^ Should be 698.582!
>>
>> This problem is caused by rotten packets, which are received after
>> polling but before interrupts are enabled again. This can be fixed by
>> checking for pending work and rescheduling if necessary after interrupts
>> has been enabled again.
>>
>> Fixes: 403f69bbdbad ("tsnep: Add TSN endpoint Ethernet MAC driver")
>> Signed-off-by: Gerhard Engleder <gerhard@...leder-embedded.com>
> 
> For the records, when targeting the net tree, you should include the
> 'net' tag into the patch prefix, instead of 'net-next'.

Ok, I understand. Will do better next time. Thanks!

Gerhard