netdev - Re: [PATCH net-next 3/8] devlink: report extended error message in region_read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 21 Nov 2022 20:07:40 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Jacob Keller <jacob.e.keller@...el.com>
Cc:     <netdev@...r.kernel.org>, Jiri Pirko <jiri@...dia.com>
Subject: Re: [PATCH net-next 3/8] devlink: report extended error message in
 region_read_dumpit

On Mon, 21 Nov 2022 13:18:37 -0800 Jacob Keller wrote:
> > Ah damn, you're right, I thought I just missed it because it wasn't
> > at the top of the function.  
> 
> I also saw a few other cases where it might make sense to use a 
> GENL_CB_REQ_ATTR_CHECK or similar.
> 
> Unfortunately there's at least one area where we check for attributes 
> inside a function that is used in both flows which would get a bit 
> problematic :( Will see what I can come up with.

Perhaps this series is not the right place to worry about the missing
attr ext_ack for dumps. Go forward with v2, we can solve that later.

I think the info discrepancy falls under a larger problem of message
building code between doit and dump.