netdev - Re: [net 13/14] net/mlx5e: Fix MACsec update SecY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y346jo+YByPirHSm@boxer>
Date:   Wed, 23 Nov 2022 16:21:50 +0100
From:   Maciej Fijalkowski <maciej.fijalkowski@...el.com>
To:     Saeed Mahameed <saeed@...nel.org>
CC:     "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Eric Dumazet <edumazet@...gle.com>,
        "Saeed Mahameed" <saeedm@...dia.com>, <netdev@...r.kernel.org>,
        Tariq Toukan <tariqt@...dia.com>,
        Emeel Hakim <ehakim@...dia.com>, Raed Salem <raeds@...dia.com>
Subject: Re: [net 13/14] net/mlx5e: Fix MACsec update SecY

On Mon, Nov 21, 2022 at 06:25:58PM -0800, Saeed Mahameed wrote:
> From: Emeel Hakim <ehakim@...dia.com>
> 
> Currently updating SecY destroys and re-creates RX SA objects,
> the re-created RX SA objects are not identical to the destroyed
> objects and it disagree on the encryption enabled property which

nit: disagrees?

> holds the value false after recreation, this value is not
> supported with offload which leads to no traffic after an update.
> Fix by recreating an identical objects.
> 
> Fixes: 5a39816a75e5 ("net/mlx5e: Add MACsec offload SecY support")
> Signed-off-by: Emeel Hakim <ehakim@...dia.com>
> Reviewed-by: Raed Salem <raeds@...dia.com>
> Signed-off-by: Saeed Mahameed <saeedm@...dia.com>
> ---
>  drivers/net/ethernet/mellanox/mlx5/core/en_accel/macsec.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_accel/macsec.c b/drivers/net/ethernet/mellanox/mlx5/core/en_accel/macsec.c
> index 8f8a735a4501..4f96c69c6cc4 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/en_accel/macsec.c
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_accel/macsec.c
> @@ -1155,7 +1155,7 @@ static int macsec_upd_secy_hw_address(struct macsec_context *ctx,
>  				continue;
>  
>  			if (rx_sa->active) {
> -				err = mlx5e_macsec_init_sa(ctx, rx_sa, false, false);
> +				err = mlx5e_macsec_init_sa(ctx, rx_sa, true, false);
>  				if (err)
>  					goto out;
>  			}
> -- 
> 2.38.1
>