[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAK7LNARnb8NEH0aPDg=KxUqBkWj0+2-peFt7TKqaT7A+8hv0eQ@mail.gmail.com>
Date: Thu, 24 Nov 2022 01:12:34 +0900
From: Masahiro Yamada <masahiroy@...nel.org>
To: Alexander Lobakin <alobakin@...me>
Cc: linux-kbuild@...r.kernel.org, Nicolas Schier <nicolas@...sle.eu>,
Jens Axboe <axboe@...nel.dk>,
Boris Brezillon <bbrezillon@...nel.org>,
Borislav Petkov <bp@...en8.de>,
Tony Luck <tony.luck@...el.com>,
Miquel Raynal <miquel.raynal@...tlin.com>,
Vladimir Oltean <vladimir.oltean@....com>,
Alexandre Belloni <alexandre.belloni@...tlin.com>,
Derek Chickles <dchickles@...vell.com>,
Ioana Ciornei <ioana.ciornei@....com>,
Salil Mehta <salil.mehta@...wei.com>,
Sunil Goutham <sgoutham@...vell.com>,
Grygorii Strashko <grygorii.strashko@...com>,
Daniel Scally <djrscally@...il.com>,
Hans de Goede <hdegoede@...hat.com>,
Mark Brown <broonie@...nel.org>,
Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
NXP Linux Team <linux-imx@....com>, netdev@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH 10/18] EDAC: i10nm, skx: fix mixed module-builtin object
On Sun, Nov 20, 2022 at 8:08 AM Alexander Lobakin <alobakin@...me> wrote:
>
> With CONFIG_EDAC_SKX=m and CONFIG_EDAC_I10NM=y (or vice versa),
> skx_common.o are linked to a module and also to vmlinux even though
> the expected CFLAGS are different between builtins and modules:
>
> > scripts/Makefile.build:252: ./drivers/edac/Makefile: skx_common.o
> > is added to multiple modules: i10nm_edac skx_edac
>
> This is the same situation as fixed by commit 637a642f5ca5 ("zstd:
> Fixing mixed module-builtin objects").
>
> Introduce the new module, skx_edac_common, to provide the common
> functions to skx_edac and i10nm_edac. skx_adxl_{get,put}() loose
> their __init/__exit annotations in order to become exportable.
>
> Fixes: d4dc89d069aa ("EDAC, i10nm: Add a driver for Intel 10nm server processors")
> Suggested-by: Masahiro Yamada <masahiroy@...nel.org>
> Signed-off-by: Alexander Lobakin <alobakin@...me>
Reviewed-by: Masahiro Yamada <masahiroy@...nel.org>
--
Best Regards
Masahiro Yamada
Powered by blists - more mailing lists