netdev - Re: [PATCH net-next v5 04/10] net/smc: remove locks smc_client_lgr_pending and smc_server_lgr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 24 Nov 2022 02:18:13 +0800
From:   kernel test robot <lkp@...el.com>
To:     "D.Wythe" <alibuda@...ux.alibaba.com>, kgraul@...ux.ibm.com,
        wenjia@...ux.ibm.com, jaka@...ux.ibm.com
Cc:     oe-kbuild-all@...ts.linux.dev, kuba@...nel.org,
        davem@...emloft.net, netdev@...r.kernel.org,
        linux-s390@...r.kernel.org, linux-rdma@...r.kernel.org
Subject: Re: [PATCH net-next v5 04/10] net/smc: remove locks
 smc_client_lgr_pending and smc_server_lgr_pending

Hi D.Wythe",

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on net-next/master]

url:    https://github.com/intel-lab-lkp/linux/commits/D-Wythe/optimize-the-parallelism-of-SMC-R-connections/20221123-235803
patch link:    https://lore.kernel.org/r/1669218890-115854-5-git-send-email-alibuda%40linux.alibaba.com
patch subject: [PATCH net-next v5 04/10] net/smc: remove locks smc_client_lgr_pending and smc_server_lgr_pending
config: m68k-allyesconfig
compiler: m68k-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/292a3d0ad4562e58da3b3683b8ee1786b65388e2
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review D-Wythe/optimize-the-parallelism-of-SMC-R-connections/20221123-235803
        git checkout 292a3d0ad4562e58da3b3683b8ee1786b65388e2
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=m68k SHELL=/bin/bash net/smc/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

   net/smc/smc_core.c: In function 'smc_ldm_wake_function':
>> net/smc/smc_core.c:2150:23: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
    2150 |         ini->advise = (u64)key;
         |                       ^


vim +2150 net/smc/smc_core.c

  2142	
  2143	static int smc_ldm_wake_function(struct wait_queue_entry *wq_entry, unsigned int mode, int sync,
  2144					 void *key)
  2145	{
  2146		struct smc_init_info *ini = wq_entry->private;
  2147		int ret;
  2148	
  2149		wq_entry->private = ini->private;
> 2150		ini->advise = (u64)key;
  2151	
  2152		ret = woken_wake_function(wq_entry, mode, sync, NULL);
  2153		if (ret) {
  2154			/* only wake up once */
  2155			list_del_init_careful(&wq_entry->entry);
  2156			if (likely(ini->ldm))
  2157				ini->ldm->conns_pending--;
  2158		}
  2159		return ret;
  2160	}
  2161	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

View attachment "config" of type "text/plain" (282825 bytes)