netdev - Re: [PATCH net-next v2 2/7] ice: Remove gettime HW semaphore

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <55118d61-1646-b3af-57d4-dbbad88b3b6b@intel.com>
Date:   Wed, 23 Nov 2022 10:42:21 -0800
From:   Tony Nguyen <anthony.l.nguyen@...el.com>
To:     Richard Cochran <richardcochran@...il.com>
CC:     <davem@...emloft.net>, <kuba@...nel.org>, <pabeni@...hat.com>,
        <edumazet@...gle.com>,
        Karol Kolacinski <karol.kolacinski@...el.com>,
        <netdev@...r.kernel.org>, Gurucharan G <gurucharanx.g@...el.com>
Subject: Re: [PATCH net-next v2 2/7] ice: Remove gettime HW semaphore



On 11/22/2022 2:36 PM, Richard Cochran wrote:
> On Tue, Nov 22, 2022 at 02:10:42PM -0800, Tony Nguyen wrote:
>> From: Karol Kolacinski <karol.kolacinski@...el.com>
>>
>> Reading the time should not block other accesses to the PTP hardware.
>> There isn't a significant risk of reading bad values while another
>> thread is modifying the clock. Removing the hardware lock around the
>> gettime allows multiple application threads to read the clock time with
>> less contention.
> 
> NAK
> 
> Correctness comes before performance.

Will drop this patch from the series.

Thanks,
Tony