lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 23 Nov 2022 05:00:19 +0000 From: patchwork-bot+netdevbpf@...nel.org To: Ziyang Xuan (William) <william.xuanziyang@...wei.com> Cc: nbd@....name, john@...ozen.org, sean.wang@...iatek.com, Mark-MC.Lee@...iatek.com, davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com, matthias.bgg@...il.com, linux@...linux.org.uk, netdev@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, linux-mediatek@...ts.infradead.org, linux-kernel@...r.kernel.org, lorenzo@...nel.org Subject: Re: [PATCH net] net: ethernet: mtk_eth_soc: fix potential memory leak in mtk_rx_alloc() Hello: This patch was applied to netdev/net.git (master) by Jakub Kicinski <kuba@...nel.org>: On Sun, 20 Nov 2022 11:54:05 +0800 you wrote: > When fail to dma_map_single() in mtk_rx_alloc(), it returns directly. > But the memory allocated for local variable data is not freed, and > local variabel data has not been attached to ring->data[i] yet, so the > memory allocated for local variable data will not be freed outside > mtk_rx_alloc() too. Thus memory leak would occur in this scenario. > > Add skb_free_frag(data) when dma_map_single() failed. > > [...] Here is the summary with links: - [net] net: ethernet: mtk_eth_soc: fix potential memory leak in mtk_rx_alloc() https://git.kernel.org/netdev/net/c/3213f808ae21 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
Powered by blists - more mailing lists