netdev - Re: [PATCH net-next] sfc: ensure type is valid before updating seen

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202211222117.40BF455@keescook>
Date:   Tue, 22 Nov 2022 21:17:30 -0800
From:   Kees Cook <keescook@...omium.org>
To:     edward.cree@....com
Cc:     netdev@...r.kernel.org, linux-net-drivers@....com,
        davem@...emloft.net, kuba@...nel.org, pabeni@...hat.com,
        edumazet@...gle.com, habetsm.xilinx@...il.com,
        Edward Cree <ecree.xilinx@...il.com>
Subject: Re: [PATCH net-next] sfc: ensure type is valid before updating
 seen_gen

On Mon, Nov 21, 2022 at 09:37:08PM +0000, edward.cree@....com wrote:
> From: Edward Cree <ecree.xilinx@...il.com>
> 
> In the case of invalid or corrupted v2 counter update packets,
>  efx_tc_rx_version_2() returns EFX_TC_COUNTER_TYPE_MAX.  In this case
>  we should not attempt to update generation counts as this will write
>  beyond the end of the seen_gen array.
> 
> Reported-by: coverity-bot <keescook+coverity-bot@...omium.org>
> Addresses-Coverity-ID: 1527356 ("Memory - illegal accesses")
> Fixes: 25730d8be5d8 ("sfc: add extra RX channel to receive MAE counter updates on ef100")
> Signed-off-by: Edward Cree <ecree.xilinx@...il.com>

Reviewed-by: Kees Cook <keescook@...omium.org>

-- 
Kees Cook