netdev - RE: [Intel-wired-lan] [PATCH 2/2] iavf: Fix error handling in iavf_init_module()

Open Source and information security mailing list archives

Message-ID: <DM8PR11MB562139536E10268B1FEFAEE3AB0C9@DM8PR11MB5621.namprd11.prod.outlook.com>
Date:   Wed, 23 Nov 2022 07:27:27 +0000
From:   "Jankowski, Konrad0" <konrad0.jankowski@...el.com>
To:     Yuan Can <yuancan@...wei.com>,
        "Brandeburg, Jesse" <jesse.brandeburg@...el.com>,
        "Nguyen, Anthony L" <anthony.l.nguyen@...el.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "edumazet@...gle.com" <edumazet@...gle.com>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "pabeni@...hat.com" <pabeni@...hat.com>,
        "alexander.h.duyck@...el.com" <alexander.h.duyck@...el.com>,
        "jeffrey.t.kirsher@...el.com" <jeffrey.t.kirsher@...el.com>,
        "Vick, Matthew" <matthew.vick@...el.com>,
        "Keller, Jacob E" <jacob.e.keller@...el.com>,
        "intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: RE: [Intel-wired-lan] [PATCH 2/2] iavf: Fix error handling in
 iavf_init_module()


> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On Behalf Of Yuan
> Can
> Sent: Monday, November 14, 2022 9:27 AM
> To: Brandeburg, Jesse <jesse.brandeburg@...el.com>; Nguyen, Anthony L
> <anthony.l.nguyen@...el.com>; davem@...emloft.net;
> edumazet@...gle.com; kuba@...nel.org; pabeni@...hat.com;
> alexander.h.duyck@...el.com; jeffrey.t.kirsher@...el.com; Vick, Matthew
> <matthew.vick@...el.com>; Keller, Jacob E <jacob.e.keller@...el.com>; intel-
> wired-lan@...ts.osuosl.org; netdev@...r.kernel.org
> Cc: yuancan@...wei.com
> Subject: [Intel-wired-lan] [PATCH 2/2] iavf: Fix error handling in iavf_init_module()
> 
> The iavf_init_module() won't destroy workqueue when pci_register_driver()
> failed. Call destroy_workqueue() when pci_register_driver() failed to prevent the
> resource leak.
> 
> Similar to the handling of u132_hcd_init in commit f276e002793c
> ("usb: u132-hcd: fix resource leak")
> 
> Fixes: 2803b16c10ea ("i40e/i40evf: Use private workqueue")
> Signed-off-by: Yuan Can <yuancan@...wei.com>
> ---
>  drivers/net/ethernet/intel/iavf/iavf_main.c | 9 ++++++++-
>  1 file changed, 8 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/intel/iavf/iavf_main.c
> b/drivers/net/ethernet/intel/iavf/iavf_main.c
> index 3fc572341781..69fded35e476 100644
> --- a/drivers/net/ethernet/intel/iavf/iavf_main.c
> +++ b/drivers/net/ethernet/intel/iavf/iavf_main.c
> https://lists.osuosl.org/mailman/listinfo/intel-wired-lan

Tested-by: Konrad Jankowski <konrad0.jankowski@...el.com>

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives