netdev - Re: [PATCH] can: mcba_usb: fix potential resource leak in mcba_usb_xmit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20221124144532.6u3hnvb6b2ninlxy@pengutronix.de>
Date:   Thu, 24 Nov 2022 15:45:32 +0100
From:   Marc Kleine-Budde <mkl@...gutronix.de>
To:     Jianglei Nie <niejianglei2021@....com>
Cc:     yashi@...cecubics.com, wg@...ndegger.com, davem@...emloft.net,
        edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
        mailhol.vincent@...adoo.fr, stefan.maetje@....eu,
        socketcan@...tkopp.net, hbh25y@...il.com,
        linux-can@...r.kernel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] can: mcba_usb: fix potential resource leak in
 mcba_usb_xmit_cmd()

On 20.11.2022 18:14:14, Jianglei Nie wrote:
> mcba_usb_xmit_cmd() gets free ctx by mcba_usb_get_free_ctx(). When
> mcba_usb_xmit() fails, the ctx should be freed with mcba_usb_free_ctx()
> like mcba_usb_start_xmit() does in label "xmit_failed" to avoid potential
> resource leak.
> 
> Fix it by calling mcba_usb_free_ctx() when mcba_usb_xmit() fails.
> 
> Signed-off-by: Jianglei Nie <niejianglei2021@....com>

Applied to linux-can.

Thanks,
Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)