netdev - Re: [PATCH v3 net 0/6] hsr: HSR send/recv fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3e8a822d1e9f0dad7256763cb7d2fdaf1115c0f5.camel@redhat.com>
Date:   Thu, 24 Nov 2022 16:06:15 +0100
From:   Paolo Abeni <pabeni@...hat.com>
To:     Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
        netdev@...r.kernel.org
Cc:     "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Kurt Kanzenbach <kurt@...utronix.de>
Subject: Re: [PATCH v3 net 0/6] hsr: HSR send/recv fixes

Hello,

On Wed, 2022-11-23 at 10:56 +0100, Sebastian Andrzej Siewior wrote:
> I started playing with HSR and run into a problem. Tested latest
> upstream -rc and noticed more problems. Now it appears to work.
> For testing I have a small three node setup with iperf and ping. While
> iperf doesn't complain ping reports missing packets and duplicates.

Thank you for all the good work!

I think this series is too invasive for -net at this late point of the
release cycle. Independently from that, even if contains only fixes, is
a so relevant refactor that I personally see it more suited for net-
next.

In any case it looks like you have some testing setup handy, could you
please use it as starting point to add some basic selftests?

Thanks!

Paolo
> 
> v2…v3:
> - dropped patch #7 was an optimisation.
> 
> v1…v2:
> - Replaced cmpxchg() from patch #6 with lock because RiscV does not provide
>   cmpxchg() for 16bit.
> - Added patch #3 which fixes the random crashes I observed on latest rc5 while
>   testing.
> 
> Sebastian
>