netdev - Re: [PATCH v3 net 0/6] hsr: HSR send/recv fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <75af69306b8f23d66043f0b6df9764df82ff9c5e.camel@redhat.com>
Date:   Thu, 24 Nov 2022 18:41:55 +0100
From:   Paolo Abeni <pabeni@...hat.com>
To:     Sebastian Andrzej Siewior <bigeasy@...utronix.de>
Cc:     netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Kurt Kanzenbach <kurt@...utronix.de>
Subject: Re: [PATCH v3 net 0/6] hsr: HSR send/recv fixes

On Thu, 2022-11-24 at 18:07 +0100, Sebastian Andrzej Siewior wrote:
> On 2022-11-24 16:06:15 [+0100], Paolo Abeni wrote:
> 
> > I think this series is too invasive for -net at this late point of the
> > release cycle. Independently from that, even if contains only fixes, is
> > a so relevant refactor that I personally see it more suited for net-
> > next.
> 
> As you wish. The huge patch is the first one basically reverting the
> initial change plus its fixup back to pre v5.18 time.
> Right now it is not usable here due to the double delete under RCU
> which happens randomly but usually within 30min. But it appears I'm the
> only one complaining so far ;)

I can agree that the hsr code will be in a better shaper with this
patches, but my personal concerns is with the timing. We are almost at
the end of the 6.1 release cycle. Sending relativelly large changes and
significant refactor this late would be "unusual" at best.

> If you want to merge it via next, be my guest. Can you apply it as-it
> or do I need to repost it again?

I'd like to see the self-tests, if possible. So a repost will likelly
be needed.

> > In any case it looks like you have some testing setup handy, could you
> > please use it as starting point to add some basic selftests?
> 
> This task might be within my capabilities. I guess you ask for something
> that spins a few virtual interfaces and then creates a HSR ring on top
> of it.

Exactly. Possibly you have to create different namespaces, and create
hsr devices on top of veths. There are a few existing self-tests you
can have a look to as a reference - to make a "random" example, the
setup phase in tools/testing/selftests/net/mptcp/mptcp_connect.sh.

Cheers,

Paolo