netdev - Re: [PATCH net v2] sctp: fix memory leak in sctp_stream_outq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CADvbK_e0MJVrGK8DnuUYhP9ieHotgN5YqECTvYgF1bQe5dtH1w@mail.gmail.com>
Date:   Thu, 24 Nov 2022 13:17:20 -0500
From:   Xin Long <lucien.xin@...il.com>
To:     Marcelo Ricardo Leitner <marcelo.leitner@...il.com>
Cc:     Zhengchao Shao <shaozhengchao@...wei.com>,
        linux-sctp@...r.kernel.org, netdev@...r.kernel.org,
        vyasevich@...il.com, nhorman@...driver.com, davem@...emloft.net,
        edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
        syzkaller-bugs@...glegroups.com, weiyongjun1@...wei.com,
        yuehaibing@...wei.com
Subject: Re: [PATCH net v2] sctp: fix memory leak in sctp_stream_outq_migrate()

On Thu, Nov 24, 2022 at 12:26 PM Marcelo Ricardo Leitner
<marcelo.leitner@...il.com> wrote:
>
> On Thu, Nov 24, 2022 at 09:11:00PM +0800, Zhengchao Shao wrote:
> > When sctp_stream_outq_migrate() is called to release stream out resources,
> > the memory pointed to by prio_head in stream out is not released.
> >
> > The memory leak information is as follows:
> >  unreferenced object 0xffff88801fe79f80 (size 64):
> >    comm "sctp_repo", pid 7957, jiffies 4294951704 (age 36.480s)
> >    hex dump (first 32 bytes):
> >      80 9f e7 1f 80 88 ff ff 80 9f e7 1f 80 88 ff ff  ................
> >      90 9f e7 1f 80 88 ff ff 90 9f e7 1f 80 88 ff ff  ................
> >    backtrace:
> >      [<ffffffff81b215c6>] kmalloc_trace+0x26/0x60
> >      [<ffffffff88ae517c>] sctp_sched_prio_set+0x4cc/0x770
> >      [<ffffffff88ad64f2>] sctp_stream_init_ext+0xd2/0x1b0
> >      [<ffffffff88aa2604>] sctp_sendmsg_to_asoc+0x1614/0x1a30
> >      [<ffffffff88ab7ff1>] sctp_sendmsg+0xda1/0x1ef0
> >      [<ffffffff87f765ed>] inet_sendmsg+0x9d/0xe0
> >      [<ffffffff8754b5b3>] sock_sendmsg+0xd3/0x120
> >      [<ffffffff8755446a>] __sys_sendto+0x23a/0x340
> >      [<ffffffff87554651>] __x64_sys_sendto+0xe1/0x1b0
> >      [<ffffffff89978b49>] do_syscall_64+0x39/0xb0
> >      [<ffffffff89a0008b>] entry_SYSCALL_64_after_hwframe+0x63/0xcd
> >
> > Link: https://syzkaller.appspot.com/bug?exrid=29c402e56c4760763cc0
> > Fixes: Fixes: 637784ade221 ("sctp: introduce priority based stream scheduler")
> > Signed-off-by: Zhengchao Shao <shaozhengchao@...wei.com>
> > ---
> > v2: add .free_sid hook function and use it to free a stream
>
> It's missing the change to sctp_stream_free as well. Please lets try
> to avoid having multiple paths freeing it differently as much as
> possible.
>
Right, something like:

@@ -181,9 +181,9 @@ void sctp_stream_free(struct sctp_stream *stream)
        struct sctp_sched_ops *sched = sctp_sched_ops_from_stream(stream);
        int i;

-       sched->free(stream);
+       sched->unsched_all(stream)
        for (i = 0; i < stream->outcnt; i++)
-               kfree(SCTP_SO(stream, i)->ext);
+               sctp_stream_free_ext(stream, i);
        genradix_free(&stream->out);
        genradix_free(&stream->in);
 }

Thanks.