[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <cfd1324c-ca40-4af5-a469-2e9ba897dfcc@app.fastmail.com>
Date: Fri, 25 Nov 2022 12:59:44 +0100
From: "Arnd Bergmann" <arnd@...db.de>
To: YueHaibing <yuehaibing@...wei.com>,
"David S . Miller" <davem@...emloft.net>,
"Eric Dumazet" <edumazet@...gle.com>,
"Jakub Kicinski" <kuba@...nel.org>,
"Paolo Abeni" <pabeni@...hat.com>, f.fainelli@...adcom.com,
"Naresh Kamboju" <naresh.kamboju@...aro.org>
Cc: Netdev <netdev@...r.kernel.org>, linux-kernel@...r.kernel.org,
"Greg Kroah-Hartman" <gregkh@...uxfoundation.org>
Subject: Re: [PATCH] net: broadcom: Add PTP_1588_CLOCK_OPTIONAL dependency for BCMGENET
under ARCH_BCM2835
On Fri, Nov 25, 2022, at 12:50, YueHaibing wrote:
> commit 8d820bc9d12b ("net: broadcom: Fix BCMGENET Kconfig") fixes the build
> that contain 99addbe31f55 ("net: broadcom: Select BROADCOM_PHY for BCMGENET")
> and enable BCMGENET=y but PTP_1588_CLOCK_OPTIONAL=m, which otherwise
> leads to a link failure. However this may trigger a runtime failure.
>
> Fix the original issue by propagating the PTP_1588_CLOCK_OPTIONAL dependency
> of BROADCOM_PHY down to BCMGENET.
>
> Fixes: 8d820bc9d12b ("net: broadcom: Fix BCMGENET Kconfig")
> Fixes: 99addbe31f55 ("net: broadcom: Select BROADCOM_PHY for BCMGENET")
> Reported-by: Naresh Kamboju <naresh.kamboju@...aro.org>
> Suggested-by: Arnd Bergmann <arnd@...db.de>
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>
Thanks for fixing this,
Acked-by: Arnd Bergmann <arnd@...db.de>
Powered by blists - more mailing lists