lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 25 Nov 2022 17:01:35 +0100 From: Alexander Lobakin <alexandr.lobakin@...el.com> To: "Goh, Wei Sheng" <wei.sheng.goh@...el.com> Cc: Alexander Lobakin <alexandr.lobakin@...el.com>, Giuseppe Cavallaro <peppe.cavallaro@...com>, Alexandre Torgue <alexandre.torgue@...com>, Jose Abreu <joabreu@...opsys.com>, "David S . Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Maxime Coquelin <mcoquelin.stm32@...il.com>, netdev@...r.kernel.org, linux-stm32@...md-mailman.stormreply.com, linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org, Alexandre Torgue <alexandre.torgue@...s.st.com>, Ong Boon Leong <boon.leong.ong@...el.com>, Voon Wei Feng <weifeng.voon@...el.com>, Tan Tee Min <tee.min.tan@...el.com>, Ahmad Tarmizi Noor Azura <noor.azura.ahmad.tarmizi@...el.com>, Looi Hong Aun <hong.aun.looi@...el.com> Subject: Re: [PATCH net v4] net: stmmac: Set MAC's flow control register to reflect current settings From: "Goh, Wei Sheng" <wei.sheng.goh@...el.com> Date: Wed, 23 Nov 2022 18:51:10 +0800 > Currently, pause frame register GMAC_RX_FLOW_CTRL_RFE is not updated > correctly when 'ethtool -A <IFACE> autoneg off rx off tx off' command > is issued. This fix ensures the flow control change is reflected directly > in the GMAC_RX_FLOW_CTRL_RFE register. Any particular reason why you completely ignored by review comments to the v3[0]? I'd like to see them fixed or at least replied. > > Fixes: 46f69ded988d ("net: stmmac: Use resolved link config in mac_link_up()") > Cc: <stable@...r.kernel.org> # 5.10.x > Signed-off-by: Goh, Wei Sheng <wei.sheng.goh@...el.com> > Signed-off-by: Noor Azura Ahmad Tarmizi <noor.azura.ahmad.tarmizi@...el.com> > --- > V3 -> V4: Fix commit message and incorrect insertions(+) value > V2 -> V3: Removed value assign for 'flow' in else statement based on review comments > V1 -> V2: Removed needless condition based on review comments > > drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c | 2 ++ > drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 12 ++++++++++-- > 2 files changed, 12 insertions(+), 2 deletions(-) [...] > -- > 2.17.1 [0] https://lore.kernel.org/netdev/20221123180947.488302-1-alexandr.lobakin@intel.com Thanks, Olek
Powered by blists - more mailing lists