netdev - Re: [PATCH v5 3/4] liburing: add example programs for napi busy poll

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4df015bc-b163-ed6d-2490-38b592432b82@gnuweeb.org>
Date:   Sat, 26 Nov 2022 04:34:33 +0700
From:   Ammar Faizi <ammarfaizi2@...weeb.org>
To:     Stefan Roesch <shr@...kernel.io>
Cc:     Facebook Kernel Team <kernel-team@...com>,
        Jens Axboe <axboe@...nel.dk>,
        Olivier Langlois <olivier@...llion01.com>,
        Jakub Kicinski <kuba@...nel.org>,
        netdev Mailing List <netdev@...r.kernel.org>,
        io-uring Mailing List <io-uring@...r.kernel.org>
Subject: Re: [PATCH v5 3/4] liburing: add example programs for napi busy poll

On 11/22/22 2:14 AM, Stefan Roesch wrote:
> This adds two example programs to test the napi busy poll functionality.
> It consists of a client program and a server program. To get a napi id,
> the client and the server program need to be run on different hosts.
> 
> To test the napi busy poll timeout, the -t needs to be specified. A
> reasonable value for the busy poll timeout is 100. By specifying the
> busy poll timeout on the server and the client the best results are
> accomplished.
> 
> Signed-off-by: Stefan Roesch <shr@...kernel.io>

Also, please fix your indentation. You have random indentation all
over the places.

   Applying: liburing: add example programs for napi busy poll
   .git/rebase-apply/patch:258: space before tab in indent.
           	avgRTT += ctx->rtt[i];
   .git/rebase-apply/patch:322: trailing whitespace.
   	int flag;
   .git/rebase-apply/patch:346: space before tab in indent.
                   	opt.sq_poll = true;
   .git/rebase-apply/patch:382: space before tab in indent.
           	fprintf(stderr, "inet_pton error for %s\n", optarg);
   .git/rebase-apply/patch:391: space before tab in indent.
           	fprintf(stderr, "socket() failed: (%d) %s\n", errno, strerror(errno));
   warning: squelched 6 whitespace errors
   warning: 11 lines add whitespace errors.

-- 
Ammar Faizi