netdev - RE: [PATCH net-next v5] ethtool: add netlink based get rss support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 25 Nov 2022 22:19:22 +0000
From:   "Mogilappagari, Sudheer" <sudheer.mogilappagari@...el.com>
To:     Jakub Kicinski <kuba@...nel.org>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "mkubecek@...e.cz" <mkubecek@...e.cz>,
        "andrew@...n.ch" <andrew@...n.ch>,
        "corbet@....net" <corbet@....net>,
        "Samudrala, Sridhar" <sridhar.samudrala@...el.com>,
        "Nguyen, Anthony L" <anthony.l.nguyen@...el.com>
Subject: RE: [PATCH net-next v5] ethtool: add netlink based get rss support



> -----Original Message-----
> From: Jakub Kicinski <kuba@...nel.org>
> Sent: Wednesday, November 23, 2022 7:31 PM
> > +  ``ETHTOOL_A_RSS_RINGS``              u32     Ring count
> 
> Let's not put the number of rings in RSS.
> 
> I keep having to explain to people how to calculate the correct number
> of active RX rings. If the field is in the channels API hopefully
> they'll just use it.
> 
> The max ring being in RXFH seems like a purely historic / legacy thing.

Yes. channels API has this information. If ring count is not recommended in
RSS_GET, any possibility of excluding rings info from ethtool output too?
Included rings attribute in RSS_GET because user space code gets simplified
while maintaining backward compatibility of output. 

I assume same output needs to be maintained. So, will have user space code
doing CHANNELS_GET and RSS_GET during ethtool -x. 
   
$ ethtool -x eth0
RX flow hash indirection table for eth0 with 56 RX ring(s): <<< 
    0:      0     1     2     3     4     5     6     7