netdev - Re: [PATCH/RFC net-next] tc: allow drivers to accept gact with PIPE when offloading

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAM0EoMmPjXvfeGo47KN_rAg-HsFMqK2yku4_BHu0M6G1VH48Pw@mail.gmail.com>
Date:   Mon, 28 Nov 2022 06:35:35 -0500
From:   Jamal Hadi Salim <jhs@...atatu.com>
To:     Tianyu Yuan <tianyu.yuan@...igine.com>
Cc:     Simon Horman <simon.horman@...igine.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Cong Wang <xiyou.wangcong@...il.com>,
        Davide Caratti <dcaratti@...hat.com>,
        Edward Cree <edward.cree@....com>,
        Eelco Chaudron <echaudro@...hat.com>,
        Ilya Maximets <i.maximets@....org>,
        Marcelo Leitner <mleitner@...hat.com>,
        Oz Shlomo <ozsh@...dia.com>, Paul Blakey <paulb@...dia.com>,
        Vlad Buslov <vladbu@...dia.com>,
        "dev@...nvswitch.org" <dev@...nvswitch.org>,
        oss-drivers <oss-drivers@...igine.com>,
        Ziyang Chen <ziyang.chen@...igine.com>
Subject: Re: [PATCH/RFC net-next] tc: allow drivers to accept gact with PIPE
 when offloading

On Mon, Nov 28, 2022 at 3:56 AM Tianyu Yuan <tianyu.yuan@...igine.com> wrote:
>
> Hi Jamal,
>
>
> When no action is specified, there should not be gact with PIPE, rather than a gact with drop, like:
>

Thanks for the example dumps. I think you should put them in your commit logs.

[..]

>
> About the second scenario of PIPE alone, I don’t think it should exist.
> Besides this adding a PIPE at the first place of a tc filter to update the flow stats, another
> attempt that directly store the flower stats, which is got from driver, in socket transacted
> with userspace (e.g. OVS). In this approach, we don’t have to make changes in driver. Which
> could be a better solution you think for this propose

I was thinking about a case of a filter with no actions but with
interest in a counter for that match.

i.e pseudo-tc-dsl as:
tc filter add ... flower blah action count

which translated is:
tc filter add ... flower blah action pipe

cheers,
jamal