netdev - Re: [RFC PATCH net-next 10/19] pds_core: devlink params for enabling VIF support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f7457718-cff6-e5e1-242e-89b0e118ec3f@amd.com>
Date:   Mon, 28 Nov 2022 14:26:26 -0800
From:   Shannon Nelson <shnelson@....com>
To:     Jakub Kicinski <kuba@...nel.org>,
        Shannon Nelson <snelson@...sando.io>
Cc:     netdev@...r.kernel.org, davem@...emloft.net, mst@...hat.com,
        jasowang@...hat.com, virtualization@...ts.linux-foundation.org,
        drivers@...sando.io
Subject: Re: [RFC PATCH net-next 10/19] pds_core: devlink params for enabling
 VIF support

On 11/28/22 10:29 AM, Jakub Kicinski wrote:
> On Fri, 18 Nov 2022 14:56:47 -0800 Shannon Nelson wrote:
>> +     DEVLINK_PARAM_DRIVER(PDSC_DEVLINK_PARAM_ID_LM,
>> +                          "enable_lm",
>> +                          DEVLINK_PARAM_TYPE_BOOL,
>> +                          BIT(DEVLINK_PARAM_CMODE_RUNTIME),
>> +                          pdsc_dl_enable_get,
>> +                          pdsc_dl_enable_set,
>> +                          pdsc_dl_enable_validate),
> 
> Terrible name, not vendor specific.

... but useful for starting a conversation.

How about we add
	DEVLINK_PARAM_GENERIC_ID_ENABLE_LM,

to live along with the existing
	DEVLINK_PARAM_GENERIC_ID_ENABLE_RDMA,
	DEVLINK_PARAM_GENERIC_ID_ENABLE_VNET,

By the way, thanks for your time looking through these patches.

Cheers,
sln