netdev - Re: [RFC PATCH net-next 10/19] pds_core: devlink params for enabling VIF support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <43eebffe-7ac1-6311-6973-c7a53935e42d@amd.com>
Date:   Mon, 28 Nov 2022 15:07:06 -0800
From:   Shannon Nelson <shnelson@....com>
To:     Andrew Lunn <andrew@...n.ch>
Cc:     Jakub Kicinski <kuba@...nel.org>,
        Shannon Nelson <snelson@...sando.io>, netdev@...r.kernel.org,
        davem@...emloft.net, mst@...hat.com, jasowang@...hat.com,
        virtualization@...ts.linux-foundation.org, drivers@...sando.io
Subject: Re: [RFC PATCH net-next 10/19] pds_core: devlink params for enabling
 VIF support

On 11/28/22 2:57 PM, Andrew Lunn wrote:
> On Mon, Nov 28, 2022 at 02:26:26PM -0800, Shannon Nelson wrote:
>> On 11/28/22 10:29 AM, Jakub Kicinski wrote:
>>> On Fri, 18 Nov 2022 14:56:47 -0800 Shannon Nelson wrote:
>>>> +     DEVLINK_PARAM_DRIVER(PDSC_DEVLINK_PARAM_ID_LM,
>>>> +                          "enable_lm",
>>>> +                          DEVLINK_PARAM_TYPE_BOOL,
>>>> +                          BIT(DEVLINK_PARAM_CMODE_RUNTIME),
>>>> +                          pdsc_dl_enable_get,
>>>> +                          pdsc_dl_enable_set,
>>>> +                          pdsc_dl_enable_validate),
>>>
>>> Terrible name, not vendor specific.
>>
>> ... but useful for starting a conversation.
>>
>> How about we add
>>        DEVLINK_PARAM_GENERIC_ID_ENABLE_LM,
> 
> I know we are running short of short acronyms and we have to recycle
> them, rfc5513 and all, so could you actually use
> DEVLINK_PARAM_GENERIC_ID_ENABLE_LIST_MANAGER making it clear your
> Smart NIC is running majordomo and will soon replace vger.
> 
>        Andrew

Oh, hush, someone might hear you speak of our plan to take over the 
email world!  You never know who might be listening...

On the other hand, "LM" could be expanded to "LIVE_MIGRATION", but that 
is soooo many letters to type... perhaps I'll need to set up some 
additional vim macros.

How about:
	DEVLINK_PARAM_GENERIC_ID_ENABLE_LIVE_MIGRATION

Cheers,
sln