netdev - Re: [PATCH net-next v3] dsa: lan9303: Add 3 ethtool stats

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20221128152145.486c6e4b@kernel.org>
Date:   Mon, 28 Nov 2022 15:21:45 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Jerry Ray <jerry.ray@...rochip.com>
Cc:     Andrew Lunn <andrew@...n.ch>,
        Florian Fainelli <f.fainelli@...il.com>,
        Vladimir Oltean <olteanv@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        "Paolo Abeni" <pabeni@...hat.com>, <netdev@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net-next v3] dsa: lan9303: Add 3 ethtool stats

On Mon, 28 Nov 2022 14:55:21 -0600 Jerry Ray wrote:
> These statistics are maintained by the switch and count the packets
> dropped due to buffer limits. Note that the rtnl_link_stats: rx_dropped
> statistic does not include dropped packets due to buffer exhaustion and as
> such, part of this counter would more appropriately fall under the
> rx_missed_errors.

Why not add them there as well?

Are these drops accounted for in any drop / error statistics within
rtnl_link_stats? 

It's okay to provide implementation specific breakdown via ethtool -S
but user must be able to notice that there are some drops / errors in
the system by looking at standard stats.