netdev - Re: [net 07/15] net/mlx5e: Use kvfree() in mlx5e_accel_fs_tcp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d27701ea-f538-eb62-513d-9d90c5834b29@intel.com>
Date:   Mon, 28 Nov 2022 15:34:39 -0800
From:   Jacob Keller <jacob.e.keller@...el.com>
To:     Saeed Mahameed <saeed@...nel.org>,
        Tariq Toukan <ttoukan.linux@...il.com>
CC:     "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Eric Dumazet <edumazet@...gle.com>,
        "Saeed Mahameed" <saeedm@...dia.com>, <netdev@...r.kernel.org>,
        Tariq Toukan <tariqt@...dia.com>,
        YueHaibing <yuehaibing@...wei.com>
Subject: Re: [net 07/15] net/mlx5e: Use kvfree() in
 mlx5e_accel_fs_tcp_create()



On 11/28/2022 11:55 AM, Saeed Mahameed wrote:
> On 24 Nov 10:32, Tariq Toukan wrote:
>>
>>
>> On 11/24/2022 10:10 AM, Saeed Mahameed wrote:
>>> From: YueHaibing <yuehaibing@...wei.com>
>>>
>>> 'accel_tcp' is allocated by kvzalloc(), which should freed by kvfree().
>>>
>>> Fixes: f52f2faee581 ("net/mlx5e: Introduce flow steering API")
>>> Signed-off-by: YueHaibing <yuehaibing@...wei.com>
>>> Reviewed-by: Tariq Toukan <tariqt@...dia.com>
>>> Signed-off-by: Saeed Mahameed <saeedm@...dia.com>
>>> ---
>>
>> Hi Saeed,
>> There was a v3 of this, that changes the alloc side instead.
>>
> Thanks Tariq, that patch was Marked for -next for some reason,
> and it's in my net-next queue, i think it's ok if this went to net and the
> other to net-next.

That route would make sense to me.

Thanks,
Jake