netdev - Re: [PATCH net] net: ethernet: renesas: ravb: Fix promiscuous mode after system resumed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 28 Nov 2022 12:54:37 +0530
From:   Pavan Chebbi <pavan.chebbi@...adcom.com>
To:     Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>
Cc:     s.shtylyov@....ru, davem@...emloft.net, edumazet@...gle.com,
        kuba@...nel.org, pabeni@...hat.com, netdev@...r.kernel.org,
        linux-renesas-soc@...r.kernel.org, Tho Vu <tho.vu.wh@...esas.com>
Subject: Re: [PATCH net] net: ethernet: renesas: ravb: Fix promiscuous mode
 after system resumed

On Mon, Nov 28, 2022 at 12:27 PM Yoshihiro Shimoda
<yoshihiro.shimoda.uh@...esas.com> wrote:
>
> After system resumed on some environment board, the promiscuous mode
> is disabled because the SoC turned off. So, call ravb_set_rx_mode() in
> the ravb_resume() to fix the issue.
>
> Reported-by: Tho Vu <tho.vu.wh@...esas.com>
> Fixes: 0184165b2f42 ("ravb: add sleep PM suspend/resume support")
> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>
> ---
>  drivers/net/ethernet/renesas/ravb_main.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/ethernet/renesas/ravb_main.c b/drivers/net/ethernet/renesas/ravb_main.c
> index 36324126db6d..6bc923326268 100644
> --- a/drivers/net/ethernet/renesas/ravb_main.c
> +++ b/drivers/net/ethernet/renesas/ravb_main.c
> @@ -3020,6 +3020,7 @@ static int __maybe_unused ravb_resume(struct device *dev)
>                 ret = ravb_open(ndev);
>                 if (ret < 0)
>                         return ret;
> +               ravb_set_rx_mode(ndev);
>                 netif_device_attach(ndev);
>         }
>
> --
> 2.25.1
>

Reviewed-by: Pavan Chebbi <pavan.chebbi@...adcom.com>

Download attachment "smime.p7s" of type "application/pkcs7-signature" (4209 bytes)