netdev - Re: [PATCH v2] udp_tunnel: Add checks for nla_nest_start() in __udp_tunnel_nic_dump

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20221129085025.79f9669b@kernel.org>
Date:   Tue, 29 Nov 2022 08:50:25 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     David Ahern <dsahern@...nel.org>
Cc:     Yuan Can <yuancan@...wei.com>, davem@...emloft.net,
        yoshfuji@...ux-ipv6.org, edumazet@...gle.com, pabeni@...hat.com,
        netdev@...r.kernel.org
Subject: Re: [PATCH v2] udp_tunnel: Add checks for nla_nest_start() in
 __udp_tunnel_nic_dump_write()

On Mon, 28 Nov 2022 20:09:52 -0700 David Ahern wrote:
> On 11/28/22 6:39 PM, Yuan Can wrote:
> > As the nla_nest_start() may fail with NULL returned, the return value needs
> > to be checked.
> > 
> > Fixes: c7d759eb7b12 ("ethtool: add tunnel info interface")
> > Signed-off-by: Yuan Can <yuancan@...wei.com>
> 
> Reviewed-by: David Ahern <dsahern@...nel.org>

Applying to net-next without the Fixes tag, FWIW. The next put will
fail and we'll bail all the same, this patch is pretty much a noop. 
But not the first "fix" like this we go so probably not point fighting
it.

Yuan, please try to find some other error checking to run your bots on,
I doubt any of the nla_nest_start() uses actually need error checking.