netdev - Re: [PATCH net-next v2] nfp: ethtool: support reporting link modes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 29 Nov 2022 09:45:41 +0800
From:   Yinjun Zhang <yinjun.zhang@...igine.com>
To:     alexandr.lobakin@...el.com
Cc:     andrew@...n.ch, davem@...emloft.net, kuba@...nel.org,
        louis.peens@...igine.com, netdev@...r.kernel.org,
        oss-drivers@...igine.com, pabeni@...hat.com,
        simon.horman@...igine.com, yu.xiao@...igine.com
Subject: Re: [PATCH net-next v2] nfp: ethtool: support reporting link modes

On Fri, 25 Nov 2022 15:01:50 +0100, Alexander Lobakin wrote:
<...>

> > +int nfp_nsp_read_media(struct nfp_nsp *state, void *buf, unsigned int size)
> > +{
> > +	struct nfp_nsp_command_buf_arg media = {
> > +		{
> > +			.code		= SPCODE_READ_MEDIA,
> > +			.option		= size,
> > +		},
> 
> One minor here: the initializers below are designated, but the one
> above is anonymous, there should be
> 
> 		.arg = {
> 			.code		= ...
> 			.option		= ...
> 		},
> 
> ideally.

Make sense, but we'll leave it as it is to keep it consistent with the
other similar functions in this file for now if you don't feel strongly
about it. Thanks anyway to point it out.

> Up to you whether to send a new rev or leave it as it is, from me:
> 
> Reviewed-by: Alexander Lobakin <alexandr.lobakin@...el.com>
> 
> (please pick it up manually if you send a new rev)
> 
> > +		.in_buf		= buf,
> > +		.in_size	= size,