netdev - Re: [PATCH bpf-next 0/7] selftests/bpf: Remove unnecessary mount/umount dance

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y4ZWsXKTKgm/e7P8@google.com>
Date:   Tue, 29 Nov 2022 11:00:01 -0800
From:   sdf@...gle.com
To:     Martin KaFai Lau <martin.lau@...ux.dev>
Cc:     bpf@...r.kernel.org, "'Alexei Starovoitov '" <ast@...nel.org>,
        "'Andrii Nakryiko '" <andrii@...nel.org>,
        "'Daniel Borkmann '" <daniel@...earbox.net>,
        netdev@...r.kernel.org, kernel-team@...a.com
Subject: Re: [PATCH bpf-next 0/7] selftests/bpf: Remove unnecessary
 mount/umount dance

On 11/28, Martin KaFai Lau wrote:
> From: Martin KaFai Lau <martin.lau@...nel.org>

> Some of the tests do mount/umount dance when switching netns.
> It is error-prone like  
> https://lore.kernel.org/bpf/20221123200829.2226254-1-sdf@google.com/

> Another issue is, there are many left over after running some of the  
> tests:
> #> mount | egrep sysfs | wc -l
> 19

> Instead of further debugging this dance,  this set is to avoid the needs  
> to
> do this remounting altogether.  It will then allow those tests to be run
> in parallel again.

Looks great, thank you for taking care of this! Since I'm partly to
blame for the mess, took a quick look at the series:

Acked-by: Stanislav Fomichev <sdf@...gle.com>

> Martin KaFai Lau (7):
>    selftests/bpf: Use if_nametoindex instead of reading the
>      /sys/net/class/*/ifindex
>    selftests/bpf: Avoid pinning bpf prog in the tc_redirect_dtime test
>    selftests/bpf: Avoid pinning bpf prog in the tc_redirect_peer_l3 test
>    selftests/bpf: Avoid pinning bpf prog in the netns_load_bpf() callers
>    selftests/bpf: Remove the "/sys" mount and umount dance in
>      {open,close}_netns
>    selftests/bpf: Remove serial from tests using {open,close}_netns
>    selftests/bpf: Avoid pinning prog when attaching to tc ingress in
>      btf_skc_cls_ingress

>   tools/testing/selftests/bpf/network_helpers.c |  51 +--
>   .../bpf/prog_tests/btf_skc_cls_ingress.c      |  25 +-
>   .../selftests/bpf/prog_tests/empty_skb.c      |   2 +-
>   .../selftests/bpf/prog_tests/tc_redirect.c    | 314 +++++++++---------
>   .../selftests/bpf/prog_tests/test_tunnel.c    |   2 +-
>   .../bpf/prog_tests/xdp_do_redirect.c          |   2 +-
>   .../selftests/bpf/prog_tests/xdp_synproxy.c   |   2 +-
>   7 files changed, 178 insertions(+), 220 deletions(-)

> --
> 2.30.2