netdev - Re: [PATCH, net-next] r8169: use tp_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <17e16424-a46c-f39b-2368-bc0c13e3cb6e@gmail.com>
Date:   Tue, 29 Nov 2022 23:33:08 +0100
From:   Heiner Kallweit <hkallweit1@...il.com>
To:     Juhee Kang <claudiajkang@...il.com>, nic_swsd@...ltek.com,
        davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
        pabeni@...hat.com, netdev@...r.kernel.org
Subject: Re: [PATCH, net-next] r8169: use tp_to_dev instead of open code

On 29.11.2022 17:12, Juhee Kang wrote:
> The open code is defined as a helper function(tp_to_dev) on r8169_main.c,
> which the open code is &tp->pci_dev->dev. The helper function was added
> in commit 1e1205b7d3e9 ("r8169: add helper tp_to_dev"). And then later,
> commit f1e911d5d0df ("r8169: add basic phylib support") added
> r8169_phylink_handler function but it didn't use the helper function.
> Thus, tp_to_dev() replaces the open code. This patch doesn't change logic.
> 
> Signed-off-by: Juhee Kang <claudiajkang@...il.com>

Doesn't hurt and helper is used more than once in this function.

Reviewed-by: Heiner Kallweit <hkallweit1@...il.com>