netdev - Re: [RFC PATCH net-next 17/19] pds_vdpa: add vdpa config client commands

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 29 Nov 2022 15:16:18 -0800
From:   Shannon Nelson <shnelson@....com>
To:     Jason Wang <jasowang@...hat.com>,
        Shannon Nelson <snelson@...sando.io>
Cc:     netdev@...r.kernel.org, davem@...emloft.net, kuba@...nel.org,
        mst@...hat.com, virtualization@...ts.linux-foundation.org,
        drivers@...sando.io
Subject: Re: [RFC PATCH net-next 17/19] pds_vdpa: add vdpa config client
 commands

On 11/21/22 10:32 PM, Jason Wang wrote:
> On Sat, Nov 19, 2022 at 6:57 AM Shannon Nelson <snelson@...sando.io> wrote:
>>
>> These are the adminq commands that will be needed for
>> setting up and using the vDPA device.
>>
>> Signed-off-by: Shannon Nelson <snelson@...sando.io>
>> ---
>>   drivers/vdpa/pds/Makefile   |   1 +
>>   drivers/vdpa/pds/cmds.c     | 266 ++++++++++++++++++++++++++++++++++++
>>   drivers/vdpa/pds/cmds.h     |  17 +++
>>   drivers/vdpa/pds/vdpa_dev.h |  60 ++++++++
>>   4 files changed, 344 insertions(+)
>>   create mode 100644 drivers/vdpa/pds/cmds.c
>>   create mode 100644 drivers/vdpa/pds/cmds.h
>>   create mode 100644 drivers/vdpa/pds/vdpa_dev.h
>>
> 
> [...]
> 
>> +struct pds_vdpa_device {
>> +       struct vdpa_device vdpa_dev;
>> +       struct pds_vdpa_aux *vdpa_aux;
>> +       struct pds_vdpa_hw hw;
>> +
>> +       struct virtio_net_config vn_config;
>> +       dma_addr_t vn_config_pa;
> 
> So this is the dma address not necessarily pa, we'd better drop the "pa" suffix.

Yeah, strictly speaking I suppose it isn't necessarily pa, but _pa is 
the moniker we've used throughout our drivers for this kind of thing - 
maybe not perfect, but this is where we are for now.

sln