netdev - Re: [PATCH net] tipc: re-fetch skb cb after tipc_msg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <166968841682.21086.10246937991954611.git-patchwork-notify@kernel.org>
Date:   Tue, 29 Nov 2022 02:20:16 +0000
From:   patchwork-bot+netdevbpf@...nel.org
To:     Xin Long <lucien.xin@...il.com>
Cc:     netdev@...r.kernel.org, tipc-discussion@...ts.sourceforge.net,
        davem@...emloft.net, kuba@...nel.org, edumazet@...gle.com,
        pabeni@...hat.com, jmaloy@...hat.com, ying.xue@...driver.com,
        shuali@...hat.com
Subject: Re: [PATCH net] tipc: re-fetch skb cb after tipc_msg_validate

Hello:

This patch was applied to netdev/net.git (master)
by Jakub Kicinski <kuba@...nel.org>:

On Fri, 25 Nov 2022 12:46:43 -0500 you wrote:
> As the call trace shows, the original skb was freed in tipc_msg_validate(),
> and dereferencing the old skb cb would cause an use-after-free crash.
> 
>   BUG: KASAN: use-after-free in tipc_crypto_rcv_complete+0x1835/0x2240 [tipc]
>   Call Trace:
>    <IRQ>
>    tipc_crypto_rcv_complete+0x1835/0x2240 [tipc]
>    tipc_crypto_rcv+0xd32/0x1ec0 [tipc]
>    tipc_rcv+0x744/0x1150 [tipc]
>   ...
>   Allocated by task 47078:
>    kmem_cache_alloc_node+0x158/0x4d0
>    __alloc_skb+0x1c1/0x270
>    tipc_buf_acquire+0x1e/0xe0 [tipc]
>    tipc_msg_create+0x33/0x1c0 [tipc]
>    tipc_link_build_proto_msg+0x38a/0x2100 [tipc]
>    tipc_link_timeout+0x8b8/0xef0 [tipc]
>    tipc_node_timeout+0x2a1/0x960 [tipc]
>    call_timer_fn+0x2d/0x1c0
>   ...
>   Freed by task 47078:
>    tipc_msg_validate+0x7b/0x440 [tipc]
>    tipc_crypto_rcv_complete+0x4b5/0x2240 [tipc]
>    tipc_crypto_rcv+0xd32/0x1ec0 [tipc]
>    tipc_rcv+0x744/0x1150 [tipc]
> 
> [...]

Here is the summary with links:
  - [net] tipc: re-fetch skb cb after tipc_msg_validate
    https://git.kernel.org/netdev/net/c/3067bc61fcfe

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html