lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 30 Nov 2022 14:57:06 +0100 From: Simon Horman <simon.horman@...igine.com> To: zys.zljxml@...il.com Cc: davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com, netdev@...r.kernel.org, linux-kernel@...r.kernel.org, Yushan Zhou <katrinzhou@...cent.com>, Thierry Reding <thierry.reding@...il.com>, linux-tegra@...r.kernel.org, dri-devel@...ts.freedesktop.org Subject: Re: [PATCH] net: tun: Remove redundant null checks before kfree + Thierry Reding, linux-tegra, dri-devel On Tue, Nov 29, 2022 at 04:43:29PM +0800, zys.zljxml@...il.com wrote: > From: Yushan Zhou <katrinzhou@...cent.com> > > Fix the following coccicheck warning: > ./drivers/gpu/host1x/fence.c:97:2-7: WARNING: > NULL check before some freeing functions is not needed. > > Signed-off-by: Yushan Zhou <katrinzhou@...cent.com> Hi, the change in the patch looks good to me. However, it does not appear to be a networking patch, so I think you have sent it to the wrong place. With reference to: $ ./scripts/get_maintainer.pl drivers/gpu/host1x/fence.c Thierry Reding <thierry.reding@...il.com> (supporter:DRM DRIVERS FOR NVIDIA TEGRA) David Airlie <airlied@...il.com> (maintainer:DRM DRIVERS) Daniel Vetter <daniel@...ll.ch> (maintainer:DRM DRIVERS) Sumit Semwal <sumit.semwal@...aro.org> (maintainer:DMA BUFFER SHARING FRAMEWORK) "Christian König" <christian.koenig@....com> (maintainer:DMA BUFFER SHARING FRAMEWORK) dri-devel@...ts.freedesktop.org (open list:DRM DRIVERS FOR NVIDIA TEGRA) linux-tegra@...r.kernel.org (open list:DRM DRIVERS FOR NVIDIA TEGRA) linux-kernel@...r.kernel.org (open list) linux-media@...r.kernel.org (open list:DMA BUFFER SHARING FRAMEWORK) linaro-mm-sig@...ts.linaro.org (moderated list:DMA BUFFER SHARING FRAMEWORK) And https://lore.kernel.org/dri-devel/39c44dce203112a8dfe279e8e2c4ad164e3cf5e5.1666275461.git.robin.murphy@arm.com/ I would suggest that the patch subject should be: [PATCH] gpu: host1x: Remove redundant null check before kfree And you should send it: To: Thierry Reding <thierry.reding@...il.com> Cc: linux-tegra@...r.kernel.org, dri-devel@...ts.freedesktop.org > --- > drivers/gpu/host1x/fence.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/gpu/host1x/fence.c b/drivers/gpu/host1x/fence.c > index ecab72882192..05b36bfc8b74 100644 > --- a/drivers/gpu/host1x/fence.c > +++ b/drivers/gpu/host1x/fence.c > @@ -93,8 +93,7 @@ static void host1x_syncpt_fence_release(struct dma_fence *f) > { > struct host1x_syncpt_fence *sf = to_host1x_fence(f); > > - if (sf->waiter) > - kfree(sf->waiter); > + kfree(sf->waiter); > > dma_fence_free(f); > } > -- > 2.27.0 >
Powered by blists - more mailing lists