netdev - Re: [PATCH net-next v2 2/3] net: qualcomm: rmnet: add tx packets aggregation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 1 Dec 2022 00:35:48 +0800
From:   kernel test robot <lkp@...el.com>
To:     Daniele Palmas <dnlplm@...il.com>,
        David Miller <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Eric Dumazet <edumazet@...gle.com>,
        Subash Abhinov Kasiviswanathan <quic_subashab@...cinc.com>,
        Sean Tranchetti <quic_stranche@...cinc.com>,
        Jonathan Corbet <corbet@....net>,
        Alexander Lobakin <alexandr.lobakin@...el.com>,
        Gal Pressman <gal@...dia.com>
Cc:     oe-kbuild-all@...ts.linux.dev, netdev@...r.kernel.org,
        Bjørn Mork <bjorn@...k.no>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Daniele Palmas <dnlplm@...il.com>
Subject: Re: [PATCH net-next v2 2/3] net: qualcomm: rmnet: add tx packets
 aggregation

Hi Daniele,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on net-next/master]

url:    https://github.com/intel-lab-lkp/linux/commits/Daniele-Palmas/ethtool-add-tx-aggregation-parameters/20221130-214701
patch link:    https://lore.kernel.org/r/20221130124616.1500643-3-dnlplm%40gmail.com
patch subject: [PATCH net-next v2 2/3] net: qualcomm: rmnet: add tx packets aggregation
config: m68k-allyesconfig
compiler: m68k-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/b97e1bddb6c669377fa7b14585c4acea2c9faa02
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Daniele-Palmas/ethtool-add-tx-aggregation-parameters/20221130-214701
        git checkout b97e1bddb6c669377fa7b14585c4acea2c9faa02
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=m68k SHELL=/bin/bash drivers/net/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

>> drivers/net/ethernet/qualcomm/rmnet/rmnet_map_data.c:571:22: warning: no previous prototype for 'rmnet_map_flush_tx_packet_queue' [-Wmissing-prototypes]
     571 | enum hrtimer_restart rmnet_map_flush_tx_packet_queue(struct hrtimer *t)
         |                      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~


vim +/rmnet_map_flush_tx_packet_queue +571 drivers/net/ethernet/qualcomm/rmnet/rmnet_map_data.c

   570	
 > 571	enum hrtimer_restart rmnet_map_flush_tx_packet_queue(struct hrtimer *t)
   572	{
   573		struct rmnet_port *port;
   574	
   575		port = container_of(t, struct rmnet_port, hrtimer);
   576	
   577		schedule_work(&port->agg_wq);
   578	
   579		return HRTIMER_NORESTART;
   580	}
   581	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

View attachment "config" of type "text/plain" (282825 bytes)