netdev - Re: [PATCH v2 3/3] net/ethtool/ioctl: split ethtool_get_phy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <Y4ai4tCT48r/ktbO@lunn.ch>
Date:   Wed, 30 Nov 2022 01:25:06 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Daniil Tatianin <d-tatianin@...dex-team.ru>
Cc:     netdev@...r.kernel.org, Michal Kubecek <mkubecek@...e.cz>,
        yc-core@...dex-team.ru, lvc-project@...uxtesting.org
Subject: Re: [PATCH v2 3/3] net/ethtool/ioctl: split ethtool_get_phy_stats
 into multiple helpers

On Tue, Nov 29, 2022 at 01:38:01PM +0300, Daniil Tatianin wrote:
> So that it's easier to follow and make sense of the branching and
> various conditions.
> 
> Stats retrieval has been split into two separate functions
> ethtool_get_phy_stats_phydev & ethtool_get_phy_stats_ethtool.
> The former attempts to retrieve the stats using phydev & phy_ops, while
> the latter uses ethtool_ops.
> 
> Actual n_stats validation & array allocation has been moved into a new
> ethtool_vzalloc_stats_array helper.
> 
> This also fixes a potential NULL dereference of
> ops->get_ethtool_phy_stats where it was getting called in an else branch
> unconditionally without making sure it was actually present.
> 
> Found by Linux Verification Center (linuxtesting.org) with the SVACE
> static analysis tool.
> 
> Signed-off-by: Daniil Tatianin <d-tatianin@...dex-team.ru>

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew