netdev - Re: [patch net-next v2] net: devlink: convert port

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20221129212736.60d3bb4b@kernel.org>
Date:   Tue, 29 Nov 2022 21:27:36 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Jiri Pirko <jiri@...nulli.us>
Cc:     netdev@...r.kernel.org, davem@...emloft.net, pabeni@...hat.com,
        edumazet@...gle.com
Subject: Re: [patch net-next v2] net: devlink: convert port_list into xarray

On Mon, 28 Nov 2022 12:08:03 +0100 Jiri Pirko wrote:
> @@ -9903,9 +9896,9 @@ void devlink_free(struct devlink *devlink)
>  	WARN_ON(!list_empty(&devlink->sb_list));
>  	WARN_ON(!list_empty(&devlink->rate_list));
>  	WARN_ON(!list_empty(&devlink->linecard_list));
> -	WARN_ON(!list_empty(&devlink->port_list));
>  
>  	xa_destroy(&devlink->snapshot_ids);
> +	xa_destroy(&devlink->ports);

Will it warn if not empty? Should we keep the warning ?