netdev - Re: [PATCH (repost) net-next] sched: add extack for tfilter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Y4cX+5n98XxFBp8o@Laptop-X1>
Date:   Wed, 30 Nov 2022 16:44:43 +0800
From:   Hangbin Liu <liuhangbin@...il.com>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     Jamal Hadi Salim <jhs@...atatu.com>,
        Marcelo Ricardo Leitner <marcelo.leitner@...il.com>,
        Cong Wang <xiyou.wangcong@...il.com>, netdev@...r.kernel.org,
        Jiri Pirko <jiri@...nulli.us>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Paolo Abeni <pabeni@...hat.com>,
        David Ahern <dsahern@...nel.org>
Subject: Re: [PATCH (repost) net-next] sched: add extack for tfilter_notify

On Tue, Nov 29, 2022 at 07:43:20AM -0800, Jakub Kicinski wrote:
> On Tue, 29 Nov 2022 16:07:04 +0800 Hangbin Liu wrote:
> > +unsigned int get_nlgroup(__u16 nlmsg_type)
> > +{
> > +	switch (nlmsg_type) {
> > +	case RTM_NEWTFILTER:
> > +	case RTM_DELTFILTER:
> > +	case RTM_NEWCHAIN:
> > +	case RTM_DELCHAIN:
> > +	case RTM_NEWTCLASS:
> > +	case RTM_DELTCLASS:
> > +	case RTM_NEWQDISC:
> > +	case RTM_DELQDISC:
> > +	case RTM_GETACTION:
> > +	case RTM_NEWACTION:
> > +	case RTM_DELACTION:
> > +		return RTNLGRP_TC;
> > +	}
> 
> These are rtnl message ids, they don't belong in af_netlink.

Oh, thanks very much! Now I got what Jamal said the
"namespace collision for attributes". I will see where we should
put the new helper.

Hangbin