netdev - Re: [patch net-next v2] net: devlink: convert port

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 30 Nov 2022 11:03:33 +0200
From:   Leon Romanovsky <leon@...nel.org>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     Jiri Pirko <jiri@...nulli.us>, netdev@...r.kernel.org,
        davem@...emloft.net, pabeni@...hat.com, edumazet@...gle.com
Subject: Re: [patch net-next v2] net: devlink: convert port_list into xarray

On Tue, Nov 29, 2022 at 09:27:36PM -0800, Jakub Kicinski wrote:
> On Mon, 28 Nov 2022 12:08:03 +0100 Jiri Pirko wrote:
> > @@ -9903,9 +9896,9 @@ void devlink_free(struct devlink *devlink)
> >  	WARN_ON(!list_empty(&devlink->sb_list));
> >  	WARN_ON(!list_empty(&devlink->rate_list));
> >  	WARN_ON(!list_empty(&devlink->linecard_list));
> > -	WARN_ON(!list_empty(&devlink->port_list));
> >  
> >  	xa_destroy(&devlink->snapshot_ids);
> > +	xa_destroy(&devlink->ports);
> 
> Will it warn if not empty?

No, it won't warn. It will simply reinitialize the XArray.