netdev - Re: [PATCH] wifi: mac80211: fix memory leak in ieee80211_register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4f37f422a0bcd8d1d2dd1bb992be30a16d335a3f.camel@sipsolutions.net>
Date:   Thu, 01 Dec 2022 13:52:57 +0100
From:   Johannes Berg <johannes@...solutions.net>
To:     Zhengchao Shao <shaozhengchao@...wei.com>,
        linux-wireless@...r.kernel.org, netdev@...r.kernel.org,
        davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
        pabeni@...hat.com
Cc:     sara.sharon@...el.com, luciano.coelho@...el.com,
        weiyongjun1@...wei.com, yuehaibing@...wei.com
Subject: Re: [PATCH] wifi: mac80211: fix memory leak in
 ieee80211_register_hw()

On Tue, 2022-11-22 at 17:11 +0800, Zhengchao Shao wrote:
> 
> +++ b/net/mac80211/iface.c
> @@ -2326,8 +2326,6 @@ void ieee80211_remove_interfaces(struct ieee80211_local *local)
>  	WARN(local->open_count, "%s: open count remains %d\n",
>  	     wiphy_name(local->hw.wiphy), local->open_count);
>  
> -	ieee80211_txq_teardown_flows(local);


This is after shutting down interfaces.

> @@ -1469,6 +1470,7 @@ void ieee80211_unregister_hw(struct ieee80211_hw *hw)
>  	 * because the driver cannot be handing us frames any
>  	 * more and the tasklet is killed.
>  	 */
> +	ieee80211_txq_teardown_flows(local);
>  	ieee80211_remove_interfaces(local);
> 

But now it's before. Why is that safe?

johannes