netdev - non-linear xdp fix for enetc driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <Y4kd2f0563PVof5O@lore-desk>
Date:   Thu, 1 Dec 2022 22:34:17 +0100
From:   Lorenzo Bianconi <lorenzo@...nel.org>
To:     claudiu.manoil@....com
Cc:     netdev@...r.kernel.org, lorenzo.bianconi@...hat.com
Subject: non-linear xdp fix for enetc driver

Hi Claudiu,

I am not very familiar with enetc driver codebase but I guess we are missing to
set frag bit in xdp_buff flag whenever the driver receives a non linear packet
in xdp mode (frag bit is needed by xdp stack). Can you please check the patch
below? (if it is ok I will post a formal fix).

Regards,
Lorenzo

diff --git a/drivers/net/ethernet/freescale/enetc/enetc.c b/drivers/net/ethernet/freescale/enetc/enetc.c
index 8671591cb750..9ddd6c1c6e0e 100644
--- a/drivers/net/ethernet/freescale/enetc/enetc.c
+++ b/drivers/net/ethernet/freescale/enetc/enetc.c
@@ -1416,6 +1416,7 @@ static void enetc_add_rx_buff_to_xdp(struct enetc_bdr *rx_ring, int i,
 	skb_frag_size_set(frag, size);
 	__skb_frag_set_page(frag, rx_swbd->page);
 
+	xdp_buff_set_frags_flag(xdp_buff);
 	shinfo->nr_frags++;
 }
 

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)